[feat] Display dynamic columns in static HTML #4172
Merged
Merged
Conversation
bruntib
force-pushed
the
static_html_dynamic
branch
from
14ab2f2 to
971ff33
Compare
vodorok
approved these changes
Apr 10, 2024
Contributor
vodorok
left a comment
vodorok
left a comment
There was a problem hiding this comment.
Can be merged if my nitpicks are not worthy of fixing.
|
|
||
| _cmp3 : function (a, b) { | ||
| return a < b ? -1 : a > b ? 1 : 0; | ||
| if (a === null) |
| review_col.appendChild(document.createTextNode(data['review-status'])); | ||
| row.appendChild(review_col); | ||
|
|
||
| var testcase_col = document.createElement('td'); |
Contributor
There was a problem hiding this comment.
I would prefer to use variables declared with let as they are less bugprone for the avg. developer. (or use const if they are not modified.)
bruntib
force-pushed
the
static_html_dynamic
branch
7 times, most recently
from
fabfb25 to
8f7e682
Compare
"CodeChecker parse -e html" command produces a static HTML that displays the reports. However, the dynamic analysis related columns were missing from this table: testcase and timestamp are now displayed too, if any.
bruntib
force-pushed
the
static_html_dynamic
branch
from
8f7e682 to
96549b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"CodeChecker parse -e html" command produces a static HTML that displays
the reports. However, the dynamic analysis related columns were missing
from this table: testcase and timestamp are now displayed too, if any.
Note: this PR consists of 2 commits. The first one is deployed in another PR (#4168). After that's merged, this one can be rebased.